Allow for cropping transparent true color pngs #1878
Merged
+119
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,9 +37,15 @@ class S3(credentials: AWSCredentials) { | |||
| } | |||
|
|
|||
| private def getContentDispositionFilename(image: Image, charset: CharSet): String = { | |||
|
|
|||
| val extension = image.source.mimeType match { | |||
| case Some("image/jpeg") => "jpg" | |||
There was a problem hiding this comment.
Might be better to identify png specifically here and fail in the "other" case.
|
👍 apart from comments. Let me know if you want to talk through the enum/case class stuff. |
Reettaphant
force-pushed
the
rv-png-alpha
branch
2 times, most recently
from
9a3a04a
to
5081fbe
Compare
Reettaphant
force-pushed
the
rv-png-alpha
branch
2 times, most recently
from
cb95383
to
b8703b2
Compare
|
@NickPapacostas This has now been updated and is ready for review |
| file: File <- ImageOperations.appendMetadata(strip, metadata) | ||
|
|
||
| //Before apps and frontend can handle PNG24s we need to pngquant PNG24 master crops | ||
| optimisedFile = if (colourType == "True Color" || colourType == "True Color with Alpha") { |
There was a problem hiding this comment.
Could it ever be True Color? I thought these would go through PNGs-that-should-really-be-JPGs route... Not a problem as such, though.
There was a problem hiding this comment.
Yes, I think I forgot all about that. I'll double check and fix it.
|
Nice job! A few little cleanups, then 👍 |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow cropping pngs with transparency. Optimised the generated assets with pngquant.
Getting this working working locally requires installing pngquant. If installing pngquant with brew, create a symlink from /usr/local/bin/pngquant to /urs/bin/pngquant